linux-kernel - RE: 2.6.33.16 Documentation/lguest breaks compile under debian x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1CCDCE528ADEE240A3F216D1B406A8F3472E9386@PDCParis.algoria.local>
Date:	Thu, 21 Jul 2011 15:58:46 +0000
From:	Jean Marc Olivieri <jmolivieri@...oria.fr>
To:	Stratos Psomadakis <psomas@....ntua.gr>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: 2.6.33.16 Documentation/lguest breaks compile under debian x86

Hi,

You were obviously right : zlib1g-dev wasn't installed.
But my point is this library is not used : so why to keep it ?

Best regards

Jean-Marc OLIVIERI
Ingénieur développement
+33 1 41 90 66 55
jmolivieri@...oria.fr



ALGORIA - Éditeur de TWS
31, rue Ernest Renan 92130 Issy-les-Moulineaux 
+33 1 41 90 66 66 (std) / +33 1 41 90 66 56 (fax)
www.algoria.fr



-----Message d'origine-----
De : Stratos Psomadakis [mailto:psomas@....ntua.gr] 
Envoyé : jeudi 21 juillet 2011 16:57
À : Jean Marc Olivieri
Cc : linux-kernel@...r.kernel.org
Objet : Re: 2.6.33.16 Documentation/lguest breaks compile under debian x86

On 07/21/2011 05:15 PM, Jean Marc Olivieri wrote:
> I'm currently using :
> Distributor ID:	Debian
> Description:	Debian GNU/Linux 6.0.2 (squeeze)
> Release:	6.0.2
> Codename:	squeeze
> On x86 PC.
>
> Kernel 2.6.33.16 fails to compile due to unfound include. Thus I got rid of it and it works.
> I successfully built kernels against :
> 	- x86
> 	- x64
>
> Here's the patch :
>
> diff -u -r a/linux-2.6.33.16/Documentation/lguest/lguest.c b/linux-2.6.33.16/Documentation/lguest/lguest.c
> --- a/linux-2.6.33.16/Documentation/lguest/lguest.c	2011-07-13 05:31:47.000000000 +0200
> +++ b/linux-2.6.33.16/Documentation/lguest/lguest.c	2011-07-21 15:16:03.331040033 +0200
> @@ -34,7 +34,6 @@
>  #include <sys/uio.h>
>  #include <termios.h>
>  #include <getopt.h>
> -#include <zlib.h>
>  #include <assert.h>
>  #include <sched.h>
>  #include <limits.h>
>
>
> Jean-Marc OLIVIERI
> Ingénieur développement
> +33 1 41 90 66 55
> jmolivieri@...oria.fr
>
>
>
> ALGORIA - Éditeur de TWS
> 31, rue Ernest Renan 92130 Issy-les-Moulineaux 
> +33 1 41 90 66 66 (std) / +33 1 41 90 66 56 (fax)
> www.algoria.fr
More recent kernels have removed the zlib.h include (upstream patch
28ff4ef7 [1]), but the patch wasn't included it in the older
-stable/-longterm kernels (obviously ;).

Anyway, you could also install the zlib headers (I think zlib1g-dev in
Debian) to make lguest launcher code compile.

[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=28ff4ef71795fe6f6c0cc06a04911c9ca09c2c11

-- 
Stratos Psomadakis
<psomas@....ntua.gr>