linux-kernel - Re: [tip:perf/urgent] perf tools, x86: Fix 32-bit compile on 64-bit system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E2852C3.50109@gmail.com>
Date:	Thu, 21 Jul 2011 10:24:35 -0600
From:	David Ahern <dsahern@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	mingo@...hat.com, linux-kernel@...r.kernel.org, fweisbec@...il.com,
	a.p.zijlstra@...llo.nl, stable@...nel.org, tglx@...utronix.de,
	mingo@...e.hu, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] perf tools, x86: Fix 32-bit compile on 64-bit
 system

On 07/21/2011 10:07 AM, H. Peter Anvin wrote:
>> The problem is the detection of the host arch without considering passed in
>> flags. This change fixes 32-bit builds via:
>>
>> make EXTRA_CFLAGS=-m32
>>
>> and 64-bit builds still reference the memcpy_64.S.
>>
> 
> But this is the wrong way to build 32-bit code on 64-bit platforms.
> make ARCH=i386 is the supported way.
> 
> 	-hpa
> 

Indeed that works fine. If that is the preferred route then the patch
needs to update the following comment in the Makefile:

# Define EXTRA_CFLAGS=-m64 or EXTRA_CFLAGS=-m32 as appropriate for
cross-builds.

to specify ARCH on the command line.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/