linux-kernel - Re: linux-next: Tree for July 21 (drivers/md/dm-raid)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110722081040.48abfff1@notabene.brown>
Date:	Fri, 22 Jul 2011 08:10:40 +1000
From:	NeilBrown <neilb@...e.de>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Jonathan Brassow <jbrassow@...hat.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-raid@...r.kernel.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, dm-devel@...hat.com
Subject: Re: linux-next: Tree for July 21 (drivers/md/dm-raid)

On Thu, 21 Jul 2011 14:56:48 -0700 Randy Dunlap <rdunlap@...otime.net> wrote:

> On Thu, 21 Jul 2011 16:55:42 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> When CONFIG_DM_RAID=m and CONFIG_MD_RAID1 is not enabled:
> 
> ERROR: "md_raid1_congested" [drivers/md/dm-raid.ko] undefined!
> 
> due to:
> 
> 	if (rs->raid_type->level == 1)
> 		return md_raid1_congested(&rs->md, bits);
> 
> Should that just be surrounded with this?
> 
> #if defined(CONFIG_MD_RAID1) || defined(CONFIG_MD_RAID1_MODULE)
> ...
> #endif
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


I suspect the right thing to do is add
   select MD_RAID1
to the 
   config DM_RAID

stanza.  What do you think Jon?

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/