linux-kernel - Re: [PATCH] arm: omap: usb: clock enable typo fix in usbhs driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110722122221.GG32058@legolas.emea.dhcp.ti.com>
Date:	Fri, 22 Jul 2011 15:22:22 +0300
From:	Felipe Balbi <balbi@...com>
To:	Keshava Munegowda <keshava_mgowda@...com>
Cc:	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, balbi@...com, gadiyar@...com,
	sameo@...ux.intel.com, parthab@...ia.ti.com, kishon@...com
Subject: Re: [PATCH] arm: omap: usb: clock enable typo fix in usbhs driver

Hi,

On Tue, Jul 19, 2011 at 07:41:43PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@...com>

$SUBJECT is quite weird. First, this is not a patch on arch/arm/*omap*/
so arm: omap: is already wrong. Also, "enable typo fix" is quite werid.

Something like: "mfd: omap-usb-host: fix clock API usage on
usbhs_disable()" would read better.

> The usbhs_disable function was invoking clk_enable api
> instead of clk_disable; The clk_disable is called to
                        ^ this semicolon should be a period.

ok, you're missing the actual problem here. How about you extend it to
read as:

usbhs_disable function was invoking clk_enable() instead of
clk_disable(), thus only increasing the clock usage counter and
preventing this particular clock from being ever turned off.

Because of that, the power domain where the USB Host subsystem is
located, would never reach lower power states.

> disble the port clocks of usbhs
    ^^ disable.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)