linux-kernel - Re: [PATCH 1/1] asm-generic: delay.h fix udelay and ndelay for 8 bit args

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311362225.2660.18.camel@localhost>
Date:	Fri, 22 Jul 2011 21:17:05 +0200
From:	Jonas Bonn <jonas@...thpole.se>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	sfr@...b.auug.org.au, Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>, arnd@...db.de
Subject: Re: [PATCH 1/1] asm-generic: delay.h fix udelay and ndelay for 8
 bit args


On Fri, 2011-07-22 at 12:11 -0700, H. Peter Anvin wrote:
> On 07/22/2011 12:04 PM, Jonas Bonn wrote:
> > 
> > On Mon, 2011-07-18 at 16:05 +0200, Jonas Bonn wrote:
> >> From: Andrew Morton <akpm@...ux-foundation.org>
> >>
> >> With a non-constant 8-bit argument, a call to udelay() generates a warning:
> >>
> > <snip>
> > 
> >> ---
> >>
> >> Here's a patch that should resolve the merge conflict.  This applies
> >> Andrew's changes on top of the new asm-generic/delay.h instead of the x86
> >> arch-specific one.  I've tested this for OpenRISC and the changed macros
> >> don't cause any problems there.
> >>
> >> Let me know if this is OK and I'll throw it into the OpenRISC tree together
> >> with the other delay.h modifications.
> >>
> > 
> > I haven't gotten any feedback on this... since the change looks
> > appropriate to merge with the other changes to asm-generic/delay.h, I'll
> > apply this patch there and carry the patch together with the other
> > asm-generic/delay.h changes in the 'openrisc' tree.  Andrew can drop the
> > patch from his series to avoid the merge conflict.
> > 
> > I hope that works for everybody...
> > 
> 
> You may want to Cc: Arnd on this, since he's the asm-generic maintainer.
> 
> Otherwise, since this is zero work on our part, it obviously works for me.
> 

Good idea!

CC:ing Arnd, too...

Arnd has already reviewed the changes to delay.h.  This is only about
getting Andrew's fixes out of his tree where they cause a merge conflict
and into asm-generic/delay.h where they belong.

Thanks,
Jonas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/