[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110722193857.GU3834@infomag.iguana.be>
Date: Fri, 22 Jul 2011 21:38:57 +0200
From: Wim Van Sebroeck <wim@...ana.be>
To: Wolfram Sang <w.sang@...gutronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Arnd Bergmann <arnd@...db.de>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/11 v3] Generic Watchdog Timer Driver
Hi Wolfram,
> Status update: I incorporated your comments and Lars-Peter Clausen's comments and
> created V4. The changes since V3 are:
> * removed overdocumentation
> * removed MODULE_SUPPORTED_DEVICE and +MODULE_ALIAS_MISCDEV
> * removed return -ENOTTY after switch (cmd) because we have the default allready
> * s/sent/send/
> * I'd suggest to swap the logic here (branch taken on error)
> * no_llseek removal squashed into patch 1
> * provide getter/setter methods for driver specific data so that we can easily do the conversion towards the device driver model
> * removed parent because this would change when we will start using the device driver model
And:
* Changed CONFIG_WATCHDOG_CORE from tristate to bool
* Added Docbook documentation for include:linuw/watchdog.h
Todo:
* Fix watchdog_unregister_device so that it returns an error if /dev/watchdog is still open.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists