linux-kernel - Re: [GIT PULL] regmap: Generic I2C and SPI register map library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2011 15:02:01 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, Grant Likely <grant@...retlab.ca>,
	Liam Girdwood <lrg@...com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [GIT PULL] regmap: Generic I2C and SPI register map library

On Fri, Jul 22, 2011 at 6:52 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
>
> I'm not 100% happy with the implementation at present (to a large extent
> due to keeping it simple for initial review, though there's some stuff
> I'm just not happy with) so I expect a bit of internal churn but the
> external interface should be solid and allow other code to start making
> use of the code.

What kind of sh*t is this?

First it says

   "There are no user servicable options here, this is an API intended
to be used by other kernel subsystems.  These subsystems should select
the appropriate symbols.:"

and then it does

   config REGMAP_I2C
        tristate
        default I2C

so now that thing turns on REGMAP_I2C and compiles in the code WITHOUT
EVEN ASKING. It's enough to enable i2c.

That is TOTALLY UNACCEPTABLE. It's pure and utter sh*t.

                       Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/