linux-kernel - Re: [PATCH] cciss: do not attempt to read from a write-only register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110722153919.ff53e0ae.akpm@linux-foundation.org>
Date:	Fri, 22 Jul 2011 15:39:19 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
Cc:	axboe@...nel.dk, stephenmcameron@...il.com,
	mikem@...rdog.cce.hp.com, linux-kernel@...r.kernel.org,
	thenzl@...hat.com, stable@...nel.org
Subject: Re: [PATCH] cciss: do not attempt to read from a write-only
 register

On Thu, 21 Jul 2011 13:16:01 -0500
"Stephen M. Cameron" <scameron@...rdog.cce.hp.com> wrote:

> From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
> 
> Most smartarrays will tolerate it, but some new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
> 
> Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>

No Cc: <stable@...nel.org>?

>  drivers/block/cciss.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h
> index 16b4d58..c049548 100644
> --- a/drivers/block/cciss.h
> +++ b/drivers/block/cciss.h
> @@ -223,7 +223,7 @@ static void SA5_submit_command( ctlr_info_t *h, CommandList_struct *c)
>  			h->ctlr, c->busaddr);
>  #endif /* CCISS_DEBUG */
>           writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> -	readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> +	readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
>  	 h->commands_outstanding++;
>  	 if ( h->commands_outstanding > h->max_outstanding)
>  		h->max_outstanding = h->commands_outstanding;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/