linux-kernel - Re: [PATCH RFC] rtmutex: Permit rt_mutex_unlock() to be invoked with irqs disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1107240118550.2702@ionos>
Date:	Sun, 24 Jul 2011 01:20:08 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>, laijs@...fujitsu.com,
	darren@...art.com, rostedt@...dmis.org, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] rtmutex: Permit rt_mutex_unlock() to be invoked with
 irqs disabled

On Sat, 23 Jul 2011, Paul E. McKenney wrote:

> On Thu, Jul 21, 2011 at 01:32:48PM +0200, Peter Zijlstra wrote:
> > On Tue, 2011-07-19 at 13:14 -0700, Paul E. McKenney wrote:
> > > Because rcu_read_unlock() can be invoked with interrupts disabled, it can
> > > in turn invoke rt_mutex_unlock() with interrupts disabled.  This situation
> > > results in lockdep splats (https://lkml.org/lkml/2011/7/7/362) because the
> > > rt_mutex structure's ->lock_wait is acquired elsewhere without disabling
> > > interrupts, which can result in deadlocks.
> > > 
> > > This commit therefore changes the rt_mutex structure's ->lock_wait
> > > acquisitions to disable interrupts.
> > > 
> > > An alternative fix is to prohibit invoking rcu_read_unlock() with
> > > interrupts disabled unless the entire preceding RCU read-side critical
> > > section has run with interrupts disabled.  However, there is already
> > > at least one case in mainline where this potential rule is violated,
> > > and there might well be many more.  These would likely be found one at
> > > a time using the lockdep-water-torture method, hence the alternative
> > > fix in the form of this commit.
> > 
> > Thomas, I'm inclined to merge this, any objections?
> 
> FWIW, it has been passing tests here.

If it's only the unlock path, I'm fine with that change.

Acked-by-me
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/