linux-kernel - Re: [PATCH 0/9 v2] Synaptics image sensor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E2A2024.9050502@canonical.com>
Date:	Fri, 22 Jul 2011 18:13:08 -0700
From:	Chase Douglas <chase.douglas@...onical.com>
To:	djkurtz@...omium.org
CC:	dmitry.torokhov@...il.com, rydberg@...omail.se,
	rubini@...l.unipv.it, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, derek.foreman@...labora.co.uk,
	daniel.stone@...labora.co.uk, olofj@...omium.org
Subject: Re: [PATCH 0/9 v2] Synaptics image sensor support

On 07/20/2011 06:38 AM, djkurtz@...omium.org wrote:
> From: Daniel Kurtz <djkurtz@...omium.org>
> Patches 4-7 add up to 3 finger support for image sensor touchpads.
> Image sensors do not suffer from the finger tracking issues that plagued
> the earlier "profile sensors", and which required the invention of "semi-mt"
> (Semi-mt reports a bounding box around two fingers instead of the fingers
> themselves).  Instead, the image sensors report the actual positions of two
> fingers using the same "Advanced Gesture Mode".  This driver uses two MT-B slots
> to report these two fingers to userspace.  In addition, it will also report
> the total number of fingers using BTN_TOOL_*TAP EV_KEY events.
> Userspace drivers should be aware that the number of fingers reported via
> BTN_TOOL_*TAP can be greater than the total number MT-B slots with non-negative
> track_ids.  Upon opening the device node, userspace should query the maximum
> values supported ABS_MT_SLOT, and note the number of supported BTN_TOOL_*TAP
> events.

I would still rather see a new property bit for devices that track and
report different numbers of touches. I think it is worthwhile to be
explicit here rather than leave it up to voodoo magic in userpace drivers.

This and the touch count transition issue I brought up in a reply to
patch 7 are my only concerns with this part of the patchset.

BTW, I found the commit messages and the code to be very comprehensible.
Good job on cleaning them up!

-- Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/