linux-kernel - Re: [patch 1/3] rtc: Handle errors correctly in rtc_irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1107230907440.2702@ionos>
Date:	Sat, 23 Jul 2011 09:15:54 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Ingo Molnar <mingo@...e.hu>,
	Ben Greear <greearb@...delatech.com>, stable@...nel.org
Subject: Re: [patch 1/3] rtc: Handle errors correctly in
 rtc_irq_set_state()

On Fri, 22 Jul 2011, Andrew Morton wrote:

> On Fri, 22 Jul 2011 09:12:50 -0000
> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > The code checks the correctness of the parameters, but unconditionally
> > arms/disarms the hrtimer.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > Cc: stable@...nel.org
> 
> The -stable maintainers will want to know why they should merge this.
> 
> The maintainers of other trees will wonder whether they should backport
> it too.
> 
> To help them make these decision we should always provide a description
> of the user-visible effects of the bug, please.

Fair enough. 

The result is that a random task might arm/disarm rtc timer and
surprise the real owner by either generating events or by stopping
them. Both undesired behaviour :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/