linux-kernel - Re: [PATCH 2/5] hugetlb: add phys addr to struct huge_bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOZdJXWUydw_9W-7g_TydpxY22Pq1ntba_HRLZQK3opvHnwjTQ@mail.gmail.com>
Date:	Sun, 24 Jul 2011 16:48:13 +0000
From:	Tabi Timur-B04825 <B04825@...escale.com>
To:	Becky Bruce <beckyb@...nel.crashing.org>
CC:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"List linux-kernel@...r.kernel.org Mailing" 
	<linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	David Gibson <david@...son.dropbear.id.au>,
	Kumar Gala <galak@...nel.crashing.org>
Subject: Re: [PATCH 2/5] hugetlb: add phys addr to struct huge_bootmem_page

On Thu, Jun 30, 2011 at 1:50 PM, Becky Bruce <beckyb@...nel.crashing.org> wrote:

> Because there was no bootmem allocation in the normal case - the non-highmem
> version stores data structure in the huge page itself.  This is perfectly fine as long
> as you have a mapping.  Since this isn't true for HIGHMEM pages, I allocate
> bootmem to store the early data structure that stores information about the
> hugepage (this happens in arch-specific code in alloc_bootmem_huge_page).

I would put this text in a comment in the code.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/