linux-kernel - Re: [PATCH] x86, olpc: Fix dependency on POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110724181512.GA24338@elte.hu>
Date:	Sun, 24 Jul 2011 20:15:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Drake <dsd@...top.org>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, rdunlap@...otime.net, linux-kernel@...r.kernel.org,
	dilinger@...ued.net
Subject: Re: [PATCH] x86, olpc: Fix dependency on POWER_SUPPLY


* Daniel Drake <dsd@...top.org> wrote:

> As reported by Randy Dunlap, CONFIG_POWER_SUPPLY=m caused a compile error:
> 
> arch/x86/built-in.o: In function `battery_status_changed':
> olpc-xo15-sci.c:(.text+0x3acdd): undefined reference to `power_supply_get_by_name'
> olpc-xo15-sci.c:(.text+0x3ad04): undefined reference to `power_supply_changed'
> 
> The SCI drivers, as bool, require POWER_SUPPLY to be builtin. Use
> select to make that a hard requirement and avoid this build failure.
> 
> Signed-off-by: Daniel Drake <dsd@...top.org>

Note that we generally try to add a Reported-by tag in such cases. 

(i've added that, no need to resend.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/