linux-kernel - Re: [PATCH 01/11] MFD: DA9052 MFD core module v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 24 Jul 2011 19:49:34 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	ashishj3 <ashish.jangam@...tcummins.com>
Cc:	arnd@...db.de, sameo@...nedhand.com, linux-kernel@...r.kernel.org,
	Dajun <dajun.chen@...semi.com>, linaro-dev@...ts.linaro.org
Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v2

On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:

> +int da9052_set_bits(struct da9052 *da9052, unsigned char reg,
> +		     unsigned char bit_mask)
> +{
> +	unsigned char val;
> +	int ret;
> +
> +	if (reg > DA9052_MAX_REG_CNT) {
> +		dev_err(da9052->dev, "invalid reg %x\n", reg);
> +		return -EINVAL;
> +	}
> +
> +	mutex_lock_interruptible(&da9052->io_lock);

Linus has now merged the regmap code (include/linux/regmap.h and
drivers/base/regmap) which means that your register I/O code should 
probably be redone in terms of that - it shoud factor a lot of code out
of the driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/