linux-kernel - Re: [PATCH v2 1/5] firmware: Add DMI entry types to the headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC-0EqgJtddENZO_=kmjSy8-bocLf+ansDbpGwbkb+a3YLakLQ@mail.gmail.com>
Date:	Sun, 24 Jul 2011 17:22:12 -0600
From:	David Hubbard <david.c.hubbard@...il.com>
To:	Mike Waychison <mikew@...gle.com>
Cc:	Linux kernel <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v2 1/5] firmware: Add DMI entry types to the headers

Hi Mike,

> In preparation for the upcoming commits, introduce the DMI entry types to
> the headers.  These type names are based on those specified in the DMTF
> SMBIOS specification version 2.7.1.
>
> Signed-off-by: Mike Waychison <mikew@...gle.com>
> ---
>  include/linux/dmi.h |   47 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 47 insertions(+), 0 deletions(-)

I noticed a missing entry w.r.t. dmi_smbios_structure_type() in dmidecode.c:

--- include/linux/dmi.h	2011-07-24 17:14:34.000000000 -0600
+++ include/linux/dmi.h	2011-07-24 17:14:49.000000000 -0600
@@ -57,6 +57,7 @@
 	DMI_ENTRY_OOB_REMOTE_ACCESS,
 	DMI_ENTRY_BIS_ENTRY,
 	DMI_ENTRY_SYSTEM_BOOT,
+	DMI_ENTRY_64_MEM_ERROR,
 	DMI_ENTRY_MGMT_DEV,
 	DMI_ENTRY_MGMT_DEV_COMPONENT,
 	DMI_ENTRY_MGMT_DEV_THRES,

I got a hint something was up when I saw that dmi_decode() in
drivers/firmware/dmi_scan.c says:

case 38: /* IPMI Device Information */

But DMI_ENTRY_IPMI_DEV == 37, so this should resolve the discrepancy.

I'm using 2.6.39, so I apologize if this information is out of date.
I'm not subscribed to the lkml; please CC me.

Cheers,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/