linux-kernel - Re: [PATCH RFC] rtmutex: Permit rt_mutex_unlock() to be invoked with irqs disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1107241057320.2702@ionos>
Date:	Sun, 24 Jul 2011 11:00:41 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>, laijs@...fujitsu.com,
	darren@...art.com, rostedt@...dmis.org, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] rtmutex: Permit rt_mutex_unlock() to be invoked with
 irqs disabled

On Sat, 23 Jul 2011, Paul E. McKenney wrote:
> On Sun, Jul 24, 2011 at 02:05:13AM +0200, Thomas Gleixner wrote:
> > On Sun, 24 Jul 2011, Thomas Gleixner wrote:
> > > > > Thomas, I'm inclined to merge this, any objections?
> > > > 
> > > > FWIW, it has been passing tests here.
> > > 
> > > If it's only the unlock path, I'm fine with that change.
> > > 
> > > Acked-by-me
> > 
> > Hrmpft. That's requiring all places to take the lock irq safe. Not
> > really amused. For -RT that's a hotpath and we can really do without
> > the irq fiddling there. That needs a bit more thought.
> 
> Indeed...  If I make only some of the lock acquisitions irq safe, lockdep
> will yell at me.  And rightfully so, as that could result in deadlock.
> 
> So, what did you have in mind?

Have no real good idea yet for this. Could you grab rt and check
whether you can observe any impact when the patch is applied?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/