linux-kernel - Re: [PATCH 1/1 v3] Staging: comedi: fix printk issue in das6402.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110724124922.GB3711@shale.localdomain>
Date:	Sun, 24 Jul 2011 15:49:22 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 1/1 v3] Staging: comedi: fix printk issue in das6402.c

On Fri, Jul 22, 2011 at 12:57:35PM +0530, Ravishankar wrote:
> @@ -322,10 +321,11 @@ static int das6402_attach(struct comedi_device *dev,
>  	if (iobase == 0)
>  		iobase = 0x300;
>  
> -	printk(KERN_INFO "comedi%d: das6402: 0x%04lx", dev->minor, iobase);
> +	pr_info("comedi%d: das6402: 0x%04lx", dev->minor, iobase);
>  
>  	if (!request_region(iobase, DAS6402_SIZE, "das6402")) {
> -		printk(KERN_CONT " I/O port conflict\n");
> +		pr_cont("I/O port conflict\n");
> +		dev_dbg(dev->hw_dev, "I/O port conflict\n");

Why are we printing this out twice here?

Really, I think maybe you shouldn't be sending cleanup patches.  It
looks easy but it's actually tricky.  Kernel programming is not a
very good or very fun place for learners.  Sorry for this.  :/

>  		return -EIO;
>  	}
>  	dev->iobase = iobase;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/