lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 Jul 2011 15:47:13 +0200 From: Ingo Molnar <mingo@...e.hu> To: Borislav Petkov <bp@...64.org> Cc: Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, "H. Peter Anvin" <hpa@...or.com>, Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, "Przywara, Andre" <Andre.Przywara@....com>, "Pohlack, Martin" <Martin.Pohlack@....com> Subject: Re: [PATCH] x86, AMD: Correct F15h IC aliasing issue * Borislav Petkov <bp@...64.org> wrote: > > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > > > index b13ed39..2d380c6 100644 > > > --- a/arch/x86/kernel/cpu/amd.c > > > +++ b/arch/x86/kernel/cpu/amd.c > > > @@ -458,6 +458,13 @@ static void __cpuinit early_init_amd(struct cpuinfo_x86 *c) > > > "with P0 frequency!\n"); > > > } > > > } > > > + > > > + if (unalias_va_addr == -1) { > > > + if (c->x86 == 0x15) > > > + unalias_va_addr = UNALIAS_VA_32 | UNALIAS_VA_64; > > > + else > > > + unalias_va_addr = 0; > > > > the placement here feels a bit wrong - don't we have run-once CPU > > quirks? > > Maybe another func ptr in struct x86_cpuinit_ops > (arch/x86/kernel/x86_init.c) would be a better place? Yeah. Assuming no objections come i'd suggest to do that as an add-on patch - so the first patch can be backported, the second patch cleans up the x86_cpuinit_ops aspect. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists