linux-kernel - [PATCH] block: use the logical OR condition at blk_flush_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <20110725110319.GA31362@july>
Date:	Mon, 25 Jul 2011 20:03:19 +0900
From:	Kyungmin Park <kmpark@...radead.org>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] block: use the logical OR condition at	blk_flush_complete_seq

From: Kyungmin Park <kyungmin.park@...sung.com>

Even though the meaning is same, use the logical OR condition instead ORing.

seq	blk_kick_flush(q)	queued
1	1			0		=> true
2	0			1		=> true
8	0			0		=> false

Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
---
diff --git a/block/blk-flush.c b/block/blk-flush.c
index bb21e4c..66e0acb 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -187,7 +187,7 @@ static bool blk_flush_complete_seq(struct request *rq, unsigned int seq,
 		BUG();
 	}
 
-	return blk_kick_flush(q) | queued;
+	return blk_kick_flush(q) || queued;
 }
 
 static void flush_end_io(struct request *flush_rq, int error)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/