linux-kernel - Re: [PATCH] pstore: change mutex locking to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110725124741.GB2866@redhat.com>
Date:	Mon, 25 Jul 2011 08:47:41 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Tony Luck <tony.luck@...el.com>
Cc:	"Huang, Ying" <ying.huang@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pstore: change mutex locking to spin_locks

On Fri, Jul 22, 2011 at 04:21:14PM -0700, Tony Luck wrote:
> On Fri, Jul 22, 2011 at 3:39 PM, Luck, Tony <tony.luck@...el.com> wrote:
> > Yup - oops is the only one where the current kernel continues - all the
> > others (halt, reboot, kexec, panic) lead to the termination of the
> > current kernel - and thus no user processes that would be able to
> > see the shiny new entry in the pstore file system.
> 
> Doh - I went to look at what it would take to fix this - and found that
> I'd already implemented it:
> 
> 
>                 if (reason == KMSG_DUMP_OOPS && pstore_is_mounted())
>                         pstore_mkfile(PSTORE_TYPE_DMESG, psinfo->name, id,
>                                       psinfo->buf, hsize + l1_cpy + l2_cpy,
>                                       CURRENT_TIME, psinfo);

Right, but it still has to be created with locks surrounding it.  And the
question is what type of locks should we use.  Mutexes don't work when
called from the NMI case and spinlocks don't seem to work when called from
the OOPs (pstore_mkfile) case.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/