linux-kernel - Re: [RFC 1/4] kbuild: export MAKECMDGOALS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311599640.3064.0.camel@fedora>
Date:	Mon, 25 Jul 2011 09:14:00 -0400
From:	Steven Rostedt <srostedt@...hat.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Arnaud Lacombe <lacombar@...il.com>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/4] kbuild: export MAKECMDGOALS

On Tue, 2011-07-19 at 16:07 +0200, Michal Marek wrote:
> On 18.7.2011 21:05, Arnaud Lacombe wrote:
> > Hi,
> >
> > On Fri, Jul 1, 2011 at 7:31 PM, Arnaud Lacombe<lacombar@...il.com>  wrote:
> >> Cc: Steven Rostedt<srostedt@...hat.com>
> >> ---
> >>   Makefile |    3 +++
> >>   1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index afb8e0d..ea517fd 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -22,6 +22,9 @@ LC_COLLATE=C
> >>   LC_NUMERIC=C
> >>   export LC_COLLATE LC_NUMERIC
> >>
> >> +# Export make goals
> >> +export MAKECMDGOALS
> >> +
> >>   # We are using a recursive build, so we need to do a little thinking
> >>   # to get the ordering right.
> >>   #
> > Michal, before I send a new version of this serie, can you tell me
> > your point of view on the export of MAKECMDGOALS (or
> > KBUILD_MAKECMDGOALS) and Kconfig to the environment ?
> 
> A cleaner interface would IMO be to check the target in the makefile and 
> pass a commandline option to streamline_config.pl, so that it's easier 
> to run it manually.

I agree with this. As I've been told by many people that they prefer to
run streamline_config.pl directly.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/