linux-kernel - Re: power: bq20z75: problem with optional battery detect gpio feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110725135953.GC18062@legolas.emea.dhcp.ti.com>
Date:	Mon, 25 Jul 2011 16:59:54 +0300
From:	Felipe Balbi <balbi@...com>
To:	Andrea Galbusera <gizero@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: power: bq20z75: problem with optional battery detect gpio feature

On Mon, Jul 25, 2011 at 03:55:34PM +0200, Andrea Galbusera wrote:
> Is the in-object feature really optional?
> If battery_detect field in my bq20z75_platform_data structure is not
> explicitly set, I suspect the driver ends up requesting an irq for the
> GPIO number 0. This look indesirable.

set the gpio to -EINVAL. gpio 0 is a valid gpio number. Maybe we should
remap zero to 1, 1 to 2 and so forth... Grant ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)