linux-kernel - Re: [PATCH] dmaengine: imx-sdma: return proper error if kzalloc fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311603847.8206.14.camel@vkoul-mobl4>
Date:	Mon, 25 Jul 2011 19:54:07 +0530
From:	Vinod Koul <vkoul@...radead.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	vinod.koul@...el.com, Axel Lin <axel.lin@...il.com>,
	linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] dmaengine: imx-sdma: return proper error if kzalloc
 fails

On Tue, 2011-07-12 at 15:51 +0200, Sascha Hauer wrote:
> On Tue, Jul 12, 2011 at 09:00:13PM +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > ---
> >  drivers/dma/imx-sdma.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> Acked-by: Sascha Hauer <s.hauer@...gutronix.de>
Applied, Thanks

> 
> > 
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> > index 1ea47db..f96d038 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -1281,8 +1281,10 @@ static int __init sdma_probe(struct platform_device *pdev)
> >  		goto err_request_irq;
> >  
> >  	sdma->script_addrs = kzalloc(sizeof(*sdma->script_addrs), GFP_KERNEL);
> > -	if (!sdma->script_addrs)
> > +	if (!sdma->script_addrs) {
> > +		ret = -ENOMEM;
> >  		goto err_alloc;
> > +	}
> >  
> >  	sdma->version = pdata->sdma_version;
> >  
> > -- 
> > 1.7.4.1
> > 
> > 
> > 
> > 
> 

-- 
~Vinod Koul
Intel Corp.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/