linux-kernel - Re: [PATCH] dma: intel_mid_dma: remove redundant pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311603908.8206.17.camel@vkoul-mobl4>
Date:	Mon, 25 Jul 2011 19:55:08 +0530
From:	Vinod Koul <vkoul@...radead.org>
To:	Axel Lin <axel.lin@...il.com>
Cc:	vinod.koul@...el.com, linux-kernel@...r.kernel.org,
	Yong Wang <yong.y.wang@...el.com>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] dma: intel_mid_dma: remove redundant pci_set_drvdata
 calls

On Tue, 2011-07-19 at 14:48 +0800, Axel Lin wrote:
> Call pci_set_drvdata() once in intel_mid_dma_probe() is enough.
> Remove redundant pci_set_drvdata() calls in dma_suspend() and dma_resume().
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/dma/intel_mid_dma.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
> index f653517..8a3fdd8 100644
> --- a/drivers/dma/intel_mid_dma.c
> +++ b/drivers/dma/intel_mid_dma.c
> @@ -1351,7 +1351,6 @@ int dma_suspend(struct pci_dev *pci, pm_message_t state)
>  			return -EAGAIN;
>  	}
>  	device->state = SUSPENDED;
> -	pci_set_drvdata(pci, device);
>  	pci_save_state(pci);
>  	pci_disable_device(pci);
>  	pci_set_power_state(pci, PCI_D3hot);
> @@ -1380,7 +1379,6 @@ int dma_resume(struct pci_dev *pci)
>  	}
>  	device->state = RUNNING;
>  	iowrite32(REG_BIT0, device->dma_base + DMA_CFG);
> -	pci_set_drvdata(pci, device);
>  	return 0;
>  }
>  
Applied, Thanks

-- 
~Vinod Koul
Intel Corp.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/