linux-kernel - Re: [PATCH] dmaengine: pl330: make platform data optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jul 2011 20:33:23 +0530
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Vinod Koul <vkoul@...radead.org>
Cc:	Rob Herring <robherring2@...il.com>,
	Jassi Brar <jassi.brar@...sung.com>, vinod.koul@...el.com,
	linux-kernel@...r.kernel.org,
	Rob Herring <rob.herring@...xeda.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dmaengine: pl330: make platform data optional

On Mon, Jul 25, 2011 at 7:54 PM, Vinod Koul <vkoul@...radead.org> wrote:
> On Tue, 2011-07-12 at 20:00 -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring@...xeda.com>
>>
>> The pl330 needs platform data for describing peripheral connections, but
>> some platforms may only support memory to memory dma channels. In this
>> case, we can probe for how many channels there are and don't need the
>> platform data.
>>
>> As memcpy requests don't need channel private data to hold peripheral
>> info, allow private data to be NULL in this case.
>>
>> Signed-off-by: Rob Herring <rob.herring@...xeda.com>
>> Cc: Jassi Brar <jassi.brar@...sung.com>
>> Cc: Vinod Koul <vinod.koul@...el.com>
>> Cc: Dan Williams <dan.j.williams@...el.com>
>> ---
>>  drivers/dma/pl330.c |   64 ++++++++++++++++++++++++++++----------------------
>>  1 files changed, 36 insertions(+), 28 deletions(-)
> Applied, Thanks

Oops, sorry Rob. I failed to reply as I assured you. I have been just
too deep into other stuff.

>> @@ -717,27 +717,35 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
>>       INIT_LIST_HEAD(&pd->channels);
>>
>>       /* Initialize channel parameters */
>> -     for (i = 0; i < pdat->nr_valid_peri; i++) {
>> -             struct dma_pl330_peri *peri = &pdat->peri[i];
>> -             pch = &pdmac->peripherals[i];
>> +     num_chan = max(pdat->nr_valid_peri, (u8)pi->pcfg.num_chan);
Perhaps you need to check against NULL pointer on 'pdat' ?

Rest looks ok.

thnx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/