linux-kernel - Re: [PATCH -next] watchdog: fix it8712f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110725190241.GZ3834@infomag.iguana.be>
Date:	Mon, 25 Jul 2011 21:02:41 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>, jorge@...2.net,
	Wim Van Sebroeck <wim@...ana.be>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	linux-watchdog@...r.kernel.org, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] watchdog: fix it8712f_wdt build errors

Hi Randy,

> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Fix build errors by adding missing header file:
> 
> drivers/watchdog/it8712f_wdt.c:127: error: implicit declaration of function 'request_muxed_region'
> drivers/watchdog/it8712f_wdt.c:141: error: implicit declaration of function 'release_region'
> drivers/watchdog/it8712f_wdt.c:412: error: implicit declaration of function 'request_region'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> ---
>  drivers/watchdog/it8712f_wdt.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20110725.orig/drivers/watchdog/it8712f_wdt.c
> +++ linux-next-20110725/drivers/watchdog/it8712f_wdt.c
> @@ -31,6 +31,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/uaccess.h>
>  #include <linux/io.h>
> +#include <linux/ioport.h>
>  
>  #define NAME "it8712f_wdt"

I see what happened: The pci.h removal patch compiled ok and the patch that introduced the muxed_region code also compiled ok (with pci.h still included). However both patches together reveal the issue indeed (pci.h includes ioport.h).

Sorry about that. I have added your patch for it.

Thanks,
wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/