linux-kernel - Re: [PATCH 1/1 v2] Staging: comedi: fix printk issue in c6xdigio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E2E6199.5010409@gmail.com>
Date:	Tue, 26 Jul 2011 16:41:29 +1000
From:	Ryan Mallon <rmallon@...il.com>
To:	Ravishankar <ravishankarkm32@...il.com>
CC:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 1/1 v2] Staging: comedi: fix printk issue in c6xdigio.c

On 26/07/11 16:45, Ravishankar wrote:
> From: Ravishankar<ravi.shankar@...enturtles.in>
>
> This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankr<ravishankarkm32@...il.com>
> ---
>
>   drivers/staging/comedi/drivers/c6xdigio.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
> index e0ac825..b0b578c 100644
> --- a/drivers/staging/comedi/drivers/c6xdigio.c
> +++ b/drivers/staging/comedi/drivers/c6xdigio.c
> @@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
>   				   struct comedi_subdevice *s,
>   				   struct comedi_insn *insn, unsigned int *data)
>   {
> -	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
> +	pr_info("%s %x\n", __func__, insn->n);
>   	return insn->n;
>   }
>
> @@ -439,9 +439,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
>   	struct comedi_subdevice *s;
>
>   	iobase = it->options[0];
> -	printk("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
> +	pr_info("comedi%d: c6xdigio: 0x%04lx\n", dev->minor, iobase);
>   	if (!request_region(iobase, C6XDIGIO_SIZE, "c6xdigio")) {
> -		printk("comedi%d: I/O port conflict\n", dev->minor);
> +		pr_err("comedi%d: I/O port conflict\n", dev->minor);
>   		return -EIO;
>   	}
>   	dev->iobase = iobase;
> @@ -456,9 +456,9 @@ static int c6xdigio_attach(struct comedi_device *dev,
>
>   	irq = it->options[1];
>   	if (irq>  0)
> -		printk("comedi%d: irq = %u ignored\n", dev->minor, irq);
> +		pr_debug("%s: %x\n", __func__, insn->n);
>   	else if (irq == 0)
> -		printk("comedi%d: no irq\n", dev->minor);
> +		pr_debug("%s: %x\n", __func__, insn->n);

You are doing this without any thought at all. Not only does this 
replace a useful message with a completely useless one, but it also 
won't even compile if DEBUG is defined. It is not confidence inspiring.

~Ryan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/