linux-kernel - Re: [PATCH 16/25] dynamic_debug: require 'a' flag to explicitly mark pending queries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO+b5-rk0uuRcVDDkAbNRBOhXBUyFOF8MqaUWfueP2C0=SeOXQ@mail.gmail.com>
Date:	Tue, 26 Jul 2011 09:26:44 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	jbaron@...hat.com, joe@...ches.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, gnb@...h.org
Subject: Re: [PATCH 16/25] dynamic_debug: require 'a' flag to explicitly mark
 pending queries

On Mon, Jul 25, 2011 at 11:42 PM, Jim Cromie <jim.cromie@...il.com> wrote:
> +       if (!q1->module ^ !q2->module ||
> +               !q1->filename ^ !q2->filename ||
> +               !q1->function ^ !q2->function ||
> +               !q1->format ^ !q2->format)
> +               return false;  /* a match-spec set/unset state differs */

I'd suggest to use "!=" here instead of "^" when testing booleans for
inequality. At least for me that would make the above code easier to
read.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/