linux-kernel - Re: regulator: tps65020 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110726085043.GA7285@opensource.wolfsonmicro.com>
Date:	Tue, 26 Jul 2011 09:50:44 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Marcus Folkesson <marcus.folkesson@...il.com>
Cc:	lrg@...mlogic.co.uk, linux-kernel@...r.kernel.org
Subject: Re: regulator: tps65020 support

On Tue, Jul 26, 2011 at 12:03:46AM +0200, Marcus Folkesson wrote:

> This patch gives support for the tps65020 voltage regulator from Texas
> Instruments.
> The support is added to the existing tps65023 regulator.
> 
> It also fixes two bugs:
> * The original driver does not allow core voltage adjustments by the
> I2C bus. (clearing CORE ADJ bit in CTRL2 register).
> * The original driver does not either telling the chip that the
> DEFCORE register i changed by setting the GO bit in CTRL2.
> 
> I have read SubmittingPatches and think all should be okay (this is my
> first submit :-) ), but I still have two questions:

No, a few more issues from SubmittingPatches you need to take care of:

- Use git format-patch -M to show the diff, right now the patch just
  looks like deleting a bunch of files and adding some new ones which is
  very hard to review.
- Split out the bug fixes from the rename, one change per patch.
- Submit in the format specified in SubmittingPatches, not as an
  attachment.

> * The patch is renaming tps65023-regulator.c to tps6502x-regulator.c
> (and edits the corresponding Kconfig/Makefile) since it now handles
> both tps65020 and tps65023. Is this allowed or is the Kconfig and
> Makefile files holy or something?

That's fine but you need to take care of any users.

> * checkpatch.pl is showing two warnings about lines over 80
> characters, but this is not really truth. The lines is splitted up so
> it should not complain. Please take a look.

If you think there's a bug in checkpatch please tell the checkpatch
maintainers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/