linux-kernel - [RFC patch] DMAengine/Langwell: put tx descriptor in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJd=RBDCLp0hXNtXVSzUd4De+z9cZLpTDftnxWVGeHauAbsWaQ@mail.gmail.com>
Date:	Tue, 26 Jul 2011 20:43:54 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: [RFC patch] DMAengine/Langwell: put tx descriptor in error path

When preparing LLI based periphral transfer, if error encountered, the newly
prepared tx descriptor should be put for later recycling.

Signed-off-by: Hillf Danton <dhillf@...il.com>
---
 drivers/dma/intel_mid_dma.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
index f653517..b78a65a 100644
--- a/drivers/dma/intel_mid_dma.c
+++ b/drivers/dma/intel_mid_dma.c
@@ -793,6 +793,7 @@ static struct dma_async_tx_descriptor
*intel_mid_dma_prep_slave_sg(
 				32, 0);
 	if (NULL == desc->lli_pool) {
 		pr_err("MID_DMA:LLI pool create failed\n");
+		midc_desc_put(midc, desc);
 		return NULL;
 	}

@@ -800,6 +801,7 @@ static struct dma_async_tx_descriptor
*intel_mid_dma_prep_slave_sg(
 	if (!desc->lli) {
 		pr_err("MID_DMA: LLI alloc failed\n");
 		pci_pool_destroy(desc->lli_pool);
+		midc_desc_put(midc, desc);
 		return NULL;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/