linux-kernel - Re: [PATCH 3/3] coccicheck: add parallel execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jul 2011 15:33:05 +0200
From:	Nicolas Palix <Nicolas.Palix@...ia.fr>
To:	Greg Dietsche <gregory.dietsche@....edu>
Cc:	Joe Perches <joe@...ches.com>, julia@...u.dk,
	Gilles.Muller@...6.fr, rdunlap@...otime.net,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	cocci@...u.dk, Michal Marek <mmarek@...e.cz>
Subject: Re: [PATCH 3/3] coccicheck: add parallel execution

Hi,

On Thu, Jul 14, 2011 at 4:14 AM, Greg Dietsche <gregory.dietsche@....edu> wrote:
> On 07/12/2011 09:42 PM, Joe Perches wrote:
>>
>> On Tue, 2011-07-12 at 20:26 -0500, Greg Dietsche wrote:
>>
>>>
>>> For example to process 6 SmPL patches at the same time:
>>>        make coccicheck PARALLEL=6
>>> Results are held in /tmp until the scripts finish. By doing this the
>>> script is able to collate the results from each SmPL patch instead of
>>> interleaving them in the output.

On my system, when killing the make task, the cleanup function only
kills the first level of
children processes (shell processes) thus living spatch running, both
the frontend script and the actual code.

Could you resubmit a patch with "pkill -P $$" replaced by  "pkill -s 0"
to kill all related processes ?

That is the only problem I notice. I will thus acked your patch.
Keep Michal in CC for your resubmission as he will commit
your patch.

>>>
>>
>> You might try adding support for gnu parallel instead.
>> http://www.gnu.org/software/parallel/
>>
>>
>
> That is a very interesting and useful tool :) I'd never heard of it before.
> The man page scares me a little bit - lots of options are marked as "alpha
> testing," but the ones i tried seemed to work fine. Anyway, without any
> modifications to Coccinelle, it is possible to do this:
>
> ls scripts/coccinelle/*/*.cocci | parallel -j+0 make coccicheck COCCI={}
> MODE=patch

Maybe that alternative could be added to the documentation ?

>
> it seems to behave mostly like my patch, but doesn't cleanup quite as well
> if you decide to kill it with ctrl-c (it leaves instances of spatch
> running). On the upside, it is up to 3 seconds faster than my patch (because
> my patch waits 3 seconds before checking on the number of jobs that are
> running).
>
> Greg
>



-- 
Nicolas Palix
http://sardes.inrialpes.fr/~npalix/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/