linux-kernel - Re: [PATCH v2] dmaengine: pl330: make platform data optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311677203.24316.4.camel@vkoul-mobl4>
Date:	Tue, 26 Jul 2011 16:16:42 +0530
From:	Vinod Koul <vkoul@...radead.org>
To:	Jassi Brar <jassisinghbrar@...il.com>
Cc:	vinod.koul@...el.com, Rob Herring <robherring2@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, Rob Herring <rob.herring@...xeda.com>
Subject: Re: [PATCH v2] dmaengine: pl330: make platform data optional

On Tue, 2011-07-26 at 10:09 +0530, Jassi Brar wrote:
> On Tue, Jul 26, 2011 at 2:35 AM, Rob Herring <robherring2@...il.com> wrote:
> > From: Rob Herring <rob.herring@...xeda.com>
> >
> > The pl330 needs platform data for describing peripheral connections, but
> > some platforms may only support memory to memory dma channels. In this
> > case, we can probe for how many channels there are and don't need the
> > platform data.
> >
> > As memcpy requests don't need channel private data to hold peripheral
> > info, allow private data to be NULL in this case.
> >
> > Signed-off-by: Rob Herring <rob.herring@...xeda.com>
> > Cc: Jassi Brar <jassisinghbrar@...il.com>
> > Cc: Vinod Koul <vkoul@...radead.org>
> > Cc: Dan Williams <dan.j.williams@...el.com>
> >
> > ---
> > Vinod, Can you apply this updated version instead?
> >
> > v2:
> >  - Added null ptr check
> >
> >  drivers/dma/pl330.c |   64 ++++++++++++++++++++++++++++----------------------
> >  1 files changed, 36 insertions(+), 28 deletions(-)
> 
> Acked-by: Jassi Brar <jassisinghbrar@...il.com>
Applied thanks

-- 
~Vinod Koul
Intel Corp.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/