linux-kernel - Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311693708.2890.5.camel@doink>
Date:	Tue, 26 Jul 2011 10:21:48 -0500
From:	Alex Elder <aelder@....com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
CC:	Christoph Hellwig <hch@...radead.org>,
	Josef Bacik <josef@...hat.com>,
	<linux-fsdevel@...r.kernel.org>, <viro@...iv.linux.org.uk>,
	<jack@...e.cz>, <linux-kernel@...r.kernel.org>,
	Dave Chinner <david@...morbit.com>, <xfs@....sgi.com>
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write

On Sun, 2011-07-24 at 14:03 +0200, Markus Trippelsdorf wrote:
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> 
> Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Tested-by: Christoph Hellwig <hch@....de>

Finally looking at this I noticed the same thing Christoph
did; thanks for fixing both.  Your change got committed
yesterday via Al Viro's VFS tree.

					-Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/