linux-kernel - Re: [PATCH] xfs: Fix build breakage in xfs_iops.c when CONFIG_FS_POSIX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx3PoChMwJKbJkUoMAOvbVU+7JnaNKoyYQFVtD9g6nK1A@mail.gmail.com>
Date:	Tue, 26 Jul 2011 09:12:25 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Steven Liu <lingjiujianke@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] xfs: Fix build breakage in xfs_iops.c when
 CONFIG_FS_POSIX_ACL is not set

On Tue, Jul 26, 2011 at 2:49 AM, Christoph Hellwig <hch@...radead.org> wrote:
>
> In that case we might as well just throw it in and try it.  In the worst
> case we'll get one expansion per site that takes the address, but no-acl
> builds aren't really something worth optimizing for.

If ACL's are enabled on a system level, but not in XFS, this is more
than a small optimization. It kills the RCU walk entirely if you just
return NULL without setting the cache.

                       Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/