linux-kernel - Re: [PATCH 11/25] dynamic_debug: factor show_ddebug_query out of ddebug_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfuBxwVweGD2upqtJr=WEX3tRkr8bRYZG2sPeM=N3R0Tns7HA@mail.gmail.com>
Date:	Tue, 26 Jul 2011 10:21:15 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	Bart Van Assche <bvanassche@....org>
Cc:	jbaron@...hat.com, joe@...ches.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, gnb@...h.org
Subject: Re: [PATCH 11/25] dynamic_debug: factor show_ddebug_query out of ddebug_parse_query

On Tue, Jul 26, 2011 at 1:15 AM, Bart Van Assche <bvanassche@....org> wrote:
> On Mon, Jul 25, 2011 at 11:42 PM, Jim Cromie <jim.cromie@...il.com> wrote:
>> @@ -435,6 +448,10 @@ static int ddebug_exec_queries(char *query)
>>        char *split;
>>        int i, errs = 0, exitcode = 0, rc;
>>
>> +       prbuf_query = kmalloc(1024, GFP_KERNEL);
>> +       if (prbuf_query == NULL)
>> +               return -ENOMEM;
>> +
>>        for (i = 0; query; query = split) {
>>                split = strpbrk(query, ";\n");
>>                if (split)
>> @@ -452,6 +469,7 @@ static int ddebug_exec_queries(char *query)
>>                }
>>                i++;
>>        }
>> +       kfree(prbuf_query);
>
> The above changes invoke memory allocation and deallocation. But the
> allocated buffer isn't used anywhere - neither in this patch nor in
> any later patch ???
>
> Bart.
>


nope, that was a vestige of code before rework to use kasprintf.
now excised.

thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/