linux-kernel - Re: [git pull] vfs pile 1.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzJUdCgY=p_5tXf2z8_ctGYcwfyj9jYRvABUuu1g58VXA@mail.gmail.com>
Date:	Tue, 26 Jul 2011 09:37:01 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Steven Liu <lingjiujianke@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs pile 1.5

On Tue, Jul 26, 2011 at 9:18 AM, Christoph Hellwig <hch@...radead.org> wrote:
>
> Even getting to check_acl() requires MS_POSIXACL to be set on the
> superblock, which it won't be if CONFIG_XFS_ACL isn't set.

Ahh, ok. That thing is well-hidden behind that IS_POSIXACL() thing..
And it turns out that now that I see it, I shudder. That's another of
those potentially expensive inode indirect pointer accesses - but I
haven't seen it because my normal test-workload is as the owner of the
tree I'm traversing.

> These days we can probably kill CONFIG_FOOFS_ACL given that everyone
> now uses the generic code, and due to the deeper VFS interaction is
> more or less forced to anyway.  Historically that wasn't the case.

Yeah. And these days pretty much every single distribution uses ACL's,
which also didn't use to be the case (or even if they used them, it
wasn't a requirement: now it tends to be).

> While I agree with you that we should life it into the common code,
> the common caching is not related at all to this particular issue.

Yeah, I had missed the hidden MS_POSIX_ACL test.

So I agree, the plain NULL return for "no ACL" works fine.

Do we have a signed-off version with a changelog etc?

                          Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/