linux-kernel - Re: [PATCH v3] blk-cgroup:be able to remove the record of unplugged device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJniumVm=oH_yJAgaTzwVu1XwJfn8eAsHw2Cm0tfvg=unA6hkA@mail.gmail.com>
Date:	Tue, 26 Jul 2011 10:17:16 -0700
From:	Paul Menage <menage@...gle.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Wanlong Gao <gaowanlong@...fujitsu.com>, lizf@...fujitsu.com,
	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	wanlong.gao@...il.com
Subject: Re: [PATCH v3] blk-cgroup:be able to remove the record of unplugged device

On Tue, Jul 26, 2011 at 7:44 AM, Vivek Goyal <vgoyal@...hat.com> wrote:
>>       char *s[4], *p, *major_s = NULL, *minor_s = NULL;
>>       int ret;
>> -     unsigned long major, minor, temp;
>> +     unsigned long major, minor, weight;
>
> Do not replace temp with name weight. The place you are parsing it,
> it could be weight, bps or iops. So lets keep the generic name in
> place.

The variable currently called "temp" is only ever stored in
newpn->val.weight. iops and bps already have their own local
variables.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/