[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMjpGUdDYQiX+UwWbKYsGWRZv1q=XL7m8G=kz_Rk5cgL+oAo_Q@mail.gmail.com>
Date: Tue, 26 Jul 2011 23:58:57 -0700
From: Mike Frysinger <vapier@...too.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
Javier Herrero <jherrero@...istemas.es>
Subject: Re: [patch] blackfin: Fixup bogus ioresource init
On Sat, Jul 23, 2011 at 08:51, Thomas Gleixner wrote:
> IRQF_SHARED is not part of the IORESOURCE_IRQ bits. It's expressed by
> IORESOURCE_IRQ_SHAREABLE.
>
> IORESOURCE_IRQ_HIGHEDGE and IRQF_TRIGGER_HIGH are contradicting
> values, an interrupt can hardly be configured for both level and edge
> at the same time. This was introduced in commit 45138439(Blackfin
> arch: flash memory map and dm9000 resources updating) of course
> without any hint in the changelog what the heck this is supposed to
> do.
makes sense to me. if Javier doesnt have a problem with it, i'll pick
it up in a while (traveling atm).
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists