linux-kernel - Re: hostap_cs: add ID for LG cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E308D11.8070405@gnu.org>
Date:	Wed, 27 Jul 2011 18:11:29 -0400
From:	Pavel Roskin <proski@....org>
To:	Ondrej Zary <linux@...nbow-software.org>
CC:	Jouni Malinen <j@...fi>, linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: hostap_cs: add ID for LG cards

On 07/27/2011 04:19 PM, Ondrej Zary wrote:
> On Tuesday 26 July 2011 23:54:37 Pavel Roskin wrote:

>> I think we may want to introduce PCMCIA_DEVICE_MANF_CARD_PROD_ID3 and match
>>
>> PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 1.02", xxx)
>>
>> Maybe some other card would be supported too?  I doubt there are any
>> Agere or Symbol cards with "Version 1.02" in the third text ID.
>
> Yes, that looks good, it would match my card too:
>    product info: "LG", "11Mbps Wireless LAN PCI Card", "Version 01.02", ""
>    manfid: 0x0156, 0x0002
>    function: 6 (network)

Good to know.

> ---------------------------
>
> Add generic "Version 01.02" match (used by many different cards) to hostap_cs.
>
> This allows LG LW1100P PCI card (with integrated CardBus bridge) to work
> (tested with rev 3.0) and probably also LW1100N (PCMCIA).
>
> Signed-off-by: Ondrej Zary<linux@...nbow-software.org>

That's not the right way to submit patches.  Anyway, I sent 3 patches to 
that effect yesterday.  One in for PCMCIA, the second is for hostap_cs 
and the third is for orinoco_cs to recognize "Version 01.01" as Agere 
firmware and to stop claiming 0x0156:0x0002 unconditionally.

I have no idea how interdependent series of patches that touch more than 
one subsystem are applied, but I guess there is a standard way.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/