linux-kernel - Re: [PATCH]Remove extra semicolon's in the kernel.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Jul 2011 21:09:51 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	Andreas Schwab <schwab@...ux-m68k.org>
CC:	trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]Remove extra semicolon's in the kernel.

>> diff --git a/arch/ia64/include/asm/mca_asm.h b/arch/ia64/include/asm/mca_asm.h
>> index dd2a5b1..d57d3c0 100644
>> --- a/arch/ia64/include/asm/mca_asm.h
>> +++ b/arch/ia64/include/asm/mca_asm.h
>> @@ -46,11 +46,11 @@
>>    *	1. Put 0x7 in bits 61 thru 63.
>>    */
>>   #define DATA_PA_TO_VA(addr,temp)							\
>> -	mov	temp	= 0x7	;;							\
>> +	mov	temp	= 0x7;							\
>
> Double semicolons are significant in the ia64 assembler language.

appologize for the delay(have this thing called work!)
anyways:

ahh.. I was confused if one semicolon should be used, or two(some say 
yes, some say no etc..) and now I know for the ia64 two is used.
(thanks for the info on this)

>
>> diff --git a/scripts/setlocalversion b/scripts/setlocalversion
>> index 4d40384..e187f1f 100755
>> --- a/scripts/setlocalversion
>> +++ b/scripts/setlocalversion
>> @@ -101,7 +101,7 @@ scm_version()
>>   		# Are there uncommitted changes?
>>   		# These are represented by + after the changeset id.
>>   		case "$hgid" in
>> -			*+|*+\ *) printf '%s' -dirty ;;
>> +			*+|*+\ *) printf '%s' -dirty;
>
> Double semicolons are significant in the Bourne shell language.
>

I was torn on what to do with this. part of me said yeah it should stay, 
but then another part of me, said well maybe it was a mistake due to the 
whitespace(so I sent it out).

I will resend without the above, if there is any others let me know, and 
thank you for the help/info

> Andreas.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/