linux-kernel - Re: [PATCH v2 3/6] trace: Add tracepoints to IRQ work run handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110728132938.GE11820@somewhere.redhat.com>
Date:	Thu, 28 Jul 2011 15:29:41 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH v2 3/6] trace: Add tracepoints to IRQ work run handler

On Thu, Jul 28, 2011 at 02:12:51PM +0200, Peter Zijlstra wrote:
> On Wed, 2011-07-27 at 11:57 -0700, Vaibhav Nagarnaik wrote:
> > @@ -122,6 +123,7 @@ void irq_work_run(void)
> >  {
> >         struct irq_work *list;
> >  
> >        trace_irq_work_run_entry(0);
> >         if (this_cpu_read(irq_work_list) == NULL)
> >                 return;
> >  
> > @@ -149,6 +151,7 @@ void irq_work_run(void)
> >                               next_flags(NULL, IRQ_WORK_BUSY),
> >                               NULL);
> >         }
> > +       trace_irq_work_run_exit(0);
> >  }
> >  EXPORT_SYMBOL_GPL(irq_work_run); 
> 
> So what happens when we call irq_work_run() from the timer interrupt?
> 

We probably need something like:

void irq_work_run_interrupt(void)
{
	trace_irq_work_run_entry(0);
	irq_work_run();
	trace_irq_work_run_exit(0);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/