linux-kernel - Re: [PATCH v2 0/6] Add tracepoints to trace all system IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1311862204.2617.179.camel@laptop>
Date:	Thu, 28 Jul 2011 16:10:04 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH v2 0/6] Add tracepoints to trace all system IRQs

On Thu, 2011-07-28 at 14:31 +0200, Frederic Weisbecker wrote:
> 
> Because that requires to put the tracepoints in every interrupt sources
> for every archs instead of putting one in the generic space. 

To sum up from IRC, yes that's exactly what you need to do, because this
patch set assumes two things:

 1) that there is a 1:1 mapping between interrupt sources and generic
handlers, and

 2) that there is a neglectable amount of arch specific code for each
generic handler.

Both are false in generic. Therefore there is no option but to
instrument each and every arch specific interrupt handler.

Also, please use a single tracepoint for all that instead of this horrid
forest of random crap. Use something like arch_interrupt_enter(line_nr),
arch_interrupt_exit(line_nr).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/