linux-kernel - Re: [PATCH 1/4] USB: option driver: add PID for Vodafone-Huawei K3770

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110728151720.GA22202@kroah.com>
Date:	Thu, 28 Jul 2011 08:17:20 -0700
From:	Greg KH <greg@...ah.com>
To:	"Andrew Bird (Sphere Systems)" <ajb@...eresystems.co.uk>
Cc:	Sergei Shtylyov <sshtylyov@...sta.com>, gregkh@...e.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] USB: option driver: add PID for Vodafone-Huawei K3770

On Thu, Jul 28, 2011 at 12:10:05PM +0100, Andrew Bird (Sphere Systems) wrote:
> Hi Sergei,
> 
> On Thursday 28 July 2011, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 27-07-2011 20:03, Andrew Bird wrote:
> > > This patch adds the product ID of Huawei's Vodafone K3770 mobile
> > > broadband modem to option.c. This is necessary so that the driver gets
> > > loaded on demand without the intervention of usb_modeswitch. This has
> > > the benefit of it becoming available faster and also ensures that the
> > > option driver is not bound to a network interface that should be claimed
> > > by cdc_ether.
> > 
> >     You seem to be adding 4 product IDs with the identical patch
> > descriptions. Why not do it in a single patch?
> > 
> > > Signed-off-by: Andrew Bird <ajb@...eresystems.co.uk>
> > 
> > WBR, Sergei
> 
> 	I'm pretty new to this, but I was following the one patch per change 
> idea, so as there are four devices I did a patch for each.
> 
> Happy to squash into one if that's more acceptable to people?

As you did it is fine, I'll queue it up next week when I return from
vacation.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/