linux-kernel - Re: [PATCH] watchdog: NUMA affine kthreads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110728200532.GP2581@redhat.com>
Date:	Thu, 28 Jul 2011 16:05:32 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] watchdog: NUMA affine kthreads

On Thu, Jul 28, 2011 at 06:44:28PM +0200, Eric Dumazet wrote:
> watchdog kthreads can use kthread_create_on_node() to NUMA affine their
> stack and task_struct.

Looks good, I'll apply and test it.

Thanks.

> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Don Zickus <dzickus@...hat.com>
> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> ---
>  kernel/watchdog.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 36491cd..14cabcd 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
>  
>  	/* create the watchdog thread */
>  	if (!p) {
> -		p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
> +		p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
> +					   "watchdog/%d", cpu);
>  		if (IS_ERR(p)) {
>  			printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
>  			if (!err) {
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/