[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1107282211370.20477@swampdragon.chaosbits.net>
Date: Thu, 28 Jul 2011 22:13:32 +0200 (CEST)
From: Jesper Juhl <jj@...osbits.net>
To: linux-kernel@...r.kernel.org
cc: Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>
Subject: [RFC][PATCH] sched: take rt_rq->rt_runtime_lock around rt_rq->rt_runtime
modification
Everywhere (that I could find) where we modify rt_rq->rt_runtime we hold
rt_rq->rt_runtime_lock except in alloc_rt_sched_group(). Shouldn't we do
so - as per this patch. ???
Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
kernel/sched.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index ccacdbd..d5a3737 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8488,7 +8488,9 @@ int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
goto err_free_rq;
init_rt_rq(rt_rq, cpu_rq(i));
+ raw_spin_lock(&rt_rq->rt_runtime_lock);
rt_rq->rt_runtime = tg->rt_bandwidth.rt_runtime;
+ raw_spin_unlock(&rt_rq->rt_runtime_lock);
init_tg_rt_entry(tg, rt_rq, rt_se, i, parent->rt_se[i]);
}
--
1.7.6
--
Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists