linux-kernel - block: part_discard_alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1311897412.11874.5.camel@w-amax.beaverton.ibm.com>
Date:	Thu, 28 Jul 2011 16:56:52 -0700
From:	Max Asbock <masbock@...ux.vnet.ibm.com>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	jaxboe@...ionio.com, boyu.mt@...bao.com
Subject: block: part_discard_alignment_show patch/unpatch

Several months a patch was posted to remove the discard_alignment field
in hd_struct. And a change was made to part_discard_alignment_show to
calculate this value when queried. This patch caused crashes and was
removed again. It seems to me that the patch failed because the struct
gendisk should have been obtained like this:
struct gendisk *disk = dev_to_disk(dev->parent);
instead of 
struct gendisk *disk = dev_to_disk(dev);

Here is part of the original patch by Tao Ma:
diff --git a/fs/partitions/check.c b/fs/partitions/check.c 
index ac54697..ec4f4ae 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -255,7 +255,12 @@ ssize_t part_discard_alignment_show(struct device *dev,
 				   struct device_attribute *attr, char *buf)
 {
 	struct hd_struct *p = dev_to_part(dev);
-	return sprintf(buf, "%u\n", p->discard_alignment);
+	struct gendisk *disk = dev_to_disk(dev);
+
+	return sprintf(buf, "%u\n",
+		       (unsigned long long)queue_limit_discard_alignment(
+							&disk->queue->limits,
+							p->start_sect));
 }

The struct device that is passed in is not embedded in a struct gendisk.
Therefore de-referencing disk->queue will cause a crash. dev->parent is
embedded in a struct gendisk.

This may not be relevant for the current main-line kernel as this patch
has been backed out.
Disclaimer: I am not really familiar with this code, I just happened to
experience a crash with a (non-mainline) kernel that had this patch and
started to look at it.

- Max 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/