linux-kernel - Re: [PATCH] fs:remove a no needed mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E327776.3010903@cn.fujitsu.com>
Date:	Fri, 29 Jul 2011 17:03:50 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Wanlong Gao <gaowanlong@...fujitsu.com>
CC:	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs:remove a no needed mutex_unlock in devtmpfs

Wanlong Gao wrote:
> According ed75e95de574c99575e5f3e1d9ca59ea8c12a9cb, Al killed the
> lookup_create(), this function will return with an mutex locked,
> and it called by dev_mkdir() previously. then unlock this mutex
> in dev_mkdir(), but when lookup_create() is replaced by kern_path_create(),
> no locked mutex returned, so no need to unlock the mutex.
> 
> Al, is it right?

no.. kern_path_create() returns with i_mutex held.

> Thanks
> 
> Signed-off-by: Wanlong Gao <gaowanlong@...fujitsu.com>
> ---
>  drivers/base/devtmpfs.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
> index b89fffc..5384883 100644
> --- a/drivers/base/devtmpfs.c
> +++ b/drivers/base/devtmpfs.c
> @@ -157,7 +157,6 @@ static int dev_mkdir(const char *name, mode_t mode)
>  		/* mark as kernel-created inode */
>  		dentry->d_inode->i_private = &thread;
>  	dput(dentry);
> -	mutex_unlock(&path.dentry->d_inode->i_mutex);
>  	path_put(&path);
>  	return err;
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/