linux-kernel - Re: [PATCH] Sound: AudioScience HPI: Don't leak firmware if mem alloc fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107291106300.22532@swampdragon.chaosbits.net>
Date:	Fri, 29 Jul 2011 11:07:04 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Takashi Iwai <tiwai@...e.de>
cc:	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	Joe Perches <joe@...ches.com>,
	Eliot Blennerhassett <eblennerhassett@...ioscience.com>,
	Jaroslav Kysela <perex@...ex.cz>, support@...ioscience.com
Subject: Re: [PATCH] Sound: AudioScience HPI: Don't leak firmware if mem
 alloc fails

On Fri, 29 Jul 2011, Takashi Iwai wrote:

> At Thu, 28 Jul 2011 21:48:27 +0200 (CEST),
> Jesper Juhl wrote:
> > 
> > We leak the memory allocated to 'firmware' when we fail to
> > release_firmware() after a kmalloc() failure in hpi_dsp_code_open().
> > This patch should take care of the leak.
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > ---
> >  sound/pci/asihpi/hpidspcd.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > 	Build tested only.
> > 
> > diff --git a/sound/pci/asihpi/hpidspcd.c b/sound/pci/asihpi/hpidspcd.c
> > index 3a7afa3..8d261ef 100644
> > --- a/sound/pci/asihpi/hpidspcd.c
> > +++ b/sound/pci/asihpi/hpidspcd.c
> > @@ -85,8 +85,10 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
> >  
> >  	HPI_DEBUG_LOG(DEBUG, "dsp code %s opened\n", fw_name);
> >  	dsp_code->pvt = kmalloc(sizeof(*dsp_code->pvt), GFP_KERNEL);
> > -	if (!dsp_code->pvt)
> > +	if (!dsp_code->pvt) {
> > +		release_firmware(firmware);
> >  		return HPI_ERROR_MEMORY_ALLOC;
> > +	}
> 
> IMO, it's better to use the same error handling like others, i.e.
> "goto error2".  But you want to pass a different error code, so we'd
> need to introduce an error code variable there...
> 
Thank you for the feedback. I'll cook up a better patch tonight.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/