linux-kernel - Re: [PATCH 1/4] Docs: Typo: coordinate{,s}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMOZ1Bt3BkNeVONXu_0xoAxx=tUFLryaaW9XtPt6AxhJmTF9GA@mail.gmail.com>
Date:	Fri, 29 Jul 2011 14:02:32 +0000
From:	Michael Witten <mfwitten@...il.com>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	Jiri Kosina <trivial@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] Docs: Typo: coordinate{,s}

On Fri, Jul 29, 2011 at 13:53, Arend van Spriel <arend@...adcom.com> wrote:
> On 07/29/2011 02:46 PM, Michael Witten wrote:
>>
>> Signed-off-by: Michael Witten<mfwitten@...il.com>
>> ---
>>  include/linux/cordic.h |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/cordic.h b/include/linux/cordic.h
>> index f932093..de741da 100644
>> --- a/include/linux/cordic.h
>> +++ b/include/linux/cordic.h
>> @@ -35,8 +35,8 @@ struct cordic_iq {
>>   * @theta: angle in degrees for which i/q coordinate is to be calculated.
>>   * @coord: function output parameter holding the i/q coordinate.
>>   *
>> - * The function calculates the i/q coordinate for a given angle using
>> - * cordic algorithm. The coordinate consists of a real (i) and an
>> + * The function calculates the i/q coordinates for a given angle using
>> + * cordic algorithm. The coordinates consist of a real (i) and an
>>   * imaginary (q) part. The real part is essentially the cosine of the
>>   * angle and the imaginary part is the sine of the angle. The returned
>>   * values are scaled by 2^16 for precision. The range for theta is
>
> Most patches in this series are fine by me. However, the function takes a
> single angle as input and returns a single two-dimensional coordinate as
> output. The coordinate itself is represented by the two axis i and q. So I
> tend to say changing coordinate to coordinates is not justified here.
> However, I not a native english speaker so I may be wrong here.

Sure.

Jiri, I'll send you a pull request later with the update(s).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/