linux-kernel - Re: [PATCH 3/3] regulator: tps65023: Added support for the similiar TPS65020 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110729140342.GB19118@opensource.wolfsonmicro.com>
Date:	Fri, 29 Jul 2011 15:03:42 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Marcus Folkesson <marcus.folkesson@...il.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] regulator: tps65023: Added support for the similiar
 TPS65020 chip

On Fri, Jul 29, 2011 at 03:08:54PM +0200, Marcus Folkesson wrote:
> 2011/7/29 Mark Brown <broonie@...nsource.wolfsonmicro.com>:
> > On Wed, Jul 27, 2011 at 12:32:47PM +0200, Marcus Folkesson wrote:

> >> +static struct tps_driver_data tps65020_drv_data = {
> >> +             .info = (struct tps_info *) tps65020_regs,

> > Why do you need the cast here?  I see it's in the original driver too
> > but it looks like something that should be fixed.

> I also thought about the line, It's only for avoiding warnings from gcc.
> But I don't really understand why gcc is warning.

> gcc output:  "warning: initialization discards qualifiers from pointer
> target type".

It's complaining because the declaration of tps65020_regs doesn't match
up with that of .info.  Probably the struct member needs to be a const
pointer.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/